Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate azure/notebooks/HPO-RAPIDS.ipynb to deployment #192

Merged
merged 16 commits into from
Jul 17, 2023

Conversation

skirui-source
Copy link
Contributor

@skirui-source skirui-source commented Mar 27, 2023

Fixes #215 - This PR tracks the migration of rapids_hpo_azureml_notebook to deployment docs.

See #203 (comment) for detailed migration instructions.

Tasks

  • Decide if notebook should be migrated and add "migrate: X" label (if no also close this issue)
  • Test if notebook works
  • Fix up anything that needs changing
  • Ensure notebook has good title, description and metadata tags in the first cell
  • Replace deployment instructions with links to docs pages
  • Copy notebook into a new folder into deployment docs examples
  • Copy any supporting files to the folder
  • Add notebook to examples toctree
  • Make PR to deployment docs repo

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@skirui-source skirui-source marked this pull request as ready for review July 7, 2023 00:48
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for copying this over @skirui-source. The build failures were due to a regex bug in the Sphinx extension I wrote, I've pushed another commit to fix that up.

It looks like there are some supporting files related to this notebook like train_rapids.py and maybe a Dockerfile? Could you also include those files in the PR?

Also would you mind giving it another pass for spelling/highlighting/etc? I can spot a few places where things like URI is not capetalised, there are spaces missing between words and AmlCompute isn't code highlighted with backticks.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the intro. It mentions DGX Cloud so I'm guessing it was copied form the DGX Cloud example notebook. Could you update it to mention Azure ML instead?

@skirui-source
Copy link
Contributor Author

Ready to merge.

@skirui-source skirui-source merged commit 4062b76 into main Jul 17, 2023
3 checks passed
@skirui-source skirui-source deleted the migrate_rapids_hpo_azureml branch July 17, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate azure/notebooks/HPO-RAPIDS.ipynb to deployment docs
2 participants